Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 886773003: Fix for Hyperlinks do not open in new tab by Print preview window. (Closed)

Created:
5 years, 10 months ago by Deepak
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, raymes
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for Hyperlinks do not open in new tab by Print preview window. navigate function of navigator object is not getting called. Changes done so that navigate function of navigator will get called with proper url and newTab as true value. BUG=453307 Committed: https://crrev.com/4f43d02986afd7683687f25a51dc641902035748 Cr-Commit-Position: refs/heads/master@{#313694}

Patch Set 1 #

Patch Set 2 : Making proper call to navigate function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/pdf/pdf.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
PTAL.
5 years, 10 months ago (2015-01-29 11:22:27 UTC) #2
raymes
lgtm
5 years, 10 months ago (2015-01-29 11:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886773003/20001
5 years, 10 months ago (2015-01-29 11:59:08 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 12:58:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 12:59:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f43d02986afd7683687f25a51dc641902035748
Cr-Commit-Position: refs/heads/master@{#313694}

Powered by Google App Engine
This is Rietveld 408576698