chrome/browser/resources/pdf/pdf.js - Issue 886773003: Fix for Hyperlinks do not open in new tab by Print preview window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 886773003: Fix for Hyperlinks do not open in new tab by Print preview window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Making proper call to navigate function. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index b6d5caa5d35079af211be6911ac116be1d88236d..a207c9ebb48abd42b682148002e214b8d8f1a221 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -410,7 +410,7 @@ PDFViewer.prototype = {

case 'navigate':

// If in print preview, always open a new tab.

if (this.isPrintPreview_)

- this.navigate_(message.data.url, true);

+ this.navigator_.navigate(message.data.url, true);

else

this.navigator_.navigate(message.data.url, message.data.newTab);

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »