Add sky-drawer to the framework

This CL adds an "appish" example to the Sky examples, including a drawer widget.

R=eseidel@chromium.org, esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/fe7c4ab2e54dbfb9ba76487122fe49ccb3c58aaf

[abarth-chromium, 2015-01-29 18:46:39]

abarth@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-01-29 18:57:11]

lgtm

[esprehn, 2015-01-29 19:03:56]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-01-29 19:03:57]

lgtm w/ comments.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
File sky/framework/animation/controller.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/controller.sky:8: module.exports = class Controller {
AnimationController ? It'll print nicer in the console since module names aren't
bound to the class.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
File sky/framework/animation/curves.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/curves.sky:8: return 3 * a * (1 - m) * (1 - m) * m + 3 *
b * (1 - m) * m * m + m * m * m
I wonder if this is faster or slow than just using Math.pow()

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/curves.sky:47: linear: new Linear(),
Why expose the Cubic class not but the Linear one?

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
File sky/framework/animation/timer.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/timer.sky:7: module.exports = class Timer {
AnimationTimer, I expected this to do setTimeout from looking at the other code.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/timer.sky:32: throw "Tick already scheduled.";
new Error(...);

throwing a string is bad, you don't get a stack trace when you catch (e) { } it.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
File sky/framework/sky-drawer.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
sky/framework/sky-drawer.sky:20: position: absolute;
This is fine for now, but I sort of feel like the users should position the
drawer. In other toolkits widgets don't position themselves, you place them in
the layout.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
sky/framework/sky-drawer.sky:35: #overlay {
Is the overlay the glass effect?

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
sky/framework/sky-drawer.sky:62: this.animation_ = new
AnimationController(this);
This way to having the delegate only works when widgets have a single animation.
We'll probably need something different later.

[abarth-chromium, 2015-01-29 19:16:45]

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
File sky/framework/animation/controller.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/controller.sky:8: module.exports = class Controller {
On 2015/01/29 at 19:03:57, esprehn wrote:
> AnimationController ? It'll print nicer in the console since module names
aren't bound to the class.

Sure!

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
File sky/framework/animation/curves.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/curves.sky:8: return 3 * a * (1 - m) * (1 - m) * m + 3 *
b * (1 - m) * m * m + m * m * m
On 2015/01/29 at 19:03:57, esprehn wrote:
> I wonder if this is faster or slow than just using Math.pow()

I'll add a TODO comment with that question.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/curves.sky:8: return 3 * a * (1 - m) * (1 - m) * m + 3 *
b * (1 - m) * m * m + m * m * m
On 2015/01/29 at 19:03:57, esprehn wrote:
> I wonder if this is faster or slow than just using Math.pow()

I'll add a TODO comment with that question.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/curves.sky:47: linear: new Linear(),
On 2015/01/29 at 19:03:57, esprehn wrote:
> Why expose the Cubic class not but the Linear one?

I'll expose the Linear class.  Its constructor does't take any parameters, so
there isn't much reason to expose it.  I guess it is useful for instanceof
checks.  We need to expose the Cubic constructor so that folks can make their
own cubic curves.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
File sky/framework/animation/timer.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/timer.sky:7: module.exports = class Timer {
On 2015/01/29 at 19:03:57, esprehn wrote:
> AnimationTimer, I expected this to do setTimeout from looking at the other
code.

Good point.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/animation/...
sky/framework/animation/timer.sky:32: throw "Tick already scheduled.";
On 2015/01/29 at 19:03:57, esprehn wrote:
> new Error(...);
> 
> throwing a string is bad, you don't get a stack trace when you catch (e) { }
it.

kk

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
File sky/framework/sky-drawer.sky (right):

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
sky/framework/sky-drawer.sky:20: position: absolute;
On 2015/01/29 at 19:03:57, esprehn wrote:
> This is fine for now, but I sort of feel like the users should position the
drawer. In other toolkits widgets don't position themselves, you place them in
the layout.

Ok.  I'll move this into the scaffold.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
sky/framework/sky-drawer.sky:35: #overlay {
On 2015/01/29 at 19:03:57, esprehn wrote:
> Is the overlay the glass effect?

I should probably rename it to "content".  It's the part of the drawer where you
actually put content.

https://codereview.chromium.org/886723002/diff/40001/sky/framework/sky-drawer...
sky/framework/sky-drawer.sky:62: this.animation_ = new
AnimationController(this);
On 2015/01/29 at 19:03:57, esprehn wrote:
> This way to having the delegate only works when widgets have a single
animation. We'll probably need something different later.

Yeah.

[abarth-chromium, 2015-01-29 19:21:43]

Committed patchset #3 (id:40001) manually as
fe7c4ab2e54dbfb9ba76487122fe49ccb3c58aaf (presubmit successful).