Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 886663004: Revert of Use a WeakCell in the CallIC type vector. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
Reviewers:
mvstanton, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use a WeakCell in the CallIC type vector. (patchset #4 id:80001 of https://codereview.chromium.org/881433002/) Reason for revert: Breaks a regression test on linux isloates, and linux with gcc 4.8. Original issue's description: > Use a WeakCell in the CallIC type vector. > > This allows us to clear the IC on a more sedate schedule, just > like Load and Store ICs. > > R=ulan@chromium.org > BUG= > > Committed: https://crrev.com/bcc79d33ca6d97d9ecfcfcf110a6ea84a0225389 > Cr-Commit-Position: refs/heads/master@{#26332} TBR=ulan@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/24bfa90b3134e8ced92e9ba4959e8368f373d1d4 Cr-Commit-Position: refs/heads/master@{#26334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -319 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +10 lines, -34 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -13 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +15 lines, -33 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -17 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +12 lines, -34 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -13 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -12 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +12 lines, -37 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -13 lines 0 comments Download
M test/cctest/test-compiler.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 2 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Use a WeakCell in the CallIC type vector.
5 years, 10 months ago (2015-01-29 18:00:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886663004/1
5 years, 10 months ago (2015-01-29 18:01:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 18:01:18 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:01:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24bfa90b3134e8ced92e9ba4959e8368f373d1d4
Cr-Commit-Position: refs/heads/master@{#26334}

Powered by Google App Engine
This is Rietveld 408576698