Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 886663004: Revert of Use a WeakCell in the CallIC type vector. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index d971c3c84050d2e4568862740ea0eba1ed19defb..83a994b1c31c5c16f68854f01016b2923b586dc9 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -450,10 +450,6 @@
template <>
HValue* CodeStubGraphBuilder<CreateAllocationSiteStub>::BuildCodeStub() {
- // This stub is performance sensitive, the generated code must be tuned
- // so that it doesn't build an eager frame.
- info()->MarkMustNotHaveEagerFrame();
-
HValue* size = Add<HConstant>(AllocationSite::kSize);
HInstruction* object = Add<HAllocate>(size, HType::JSObject(), TENURED,
JS_OBJECT_TYPE);
@@ -524,36 +520,6 @@
Handle<Code> CreateAllocationSiteStub::GenerateCode() {
return DoGenerateCode(this);
}
-
-
-template <>
-HValue* CodeStubGraphBuilder<CreateWeakCellStub>::BuildCodeStub() {
- // This stub is performance sensitive, the generated code must be tuned
- // so that it doesn't build an eager frame.
- info()->MarkMustNotHaveEagerFrame();
-
- HValue* size = Add<HConstant>(WeakCell::kSize);
- HInstruction* object =
- Add<HAllocate>(size, HType::JSObject(), TENURED, JS_OBJECT_TYPE);
-
- Handle<Map> weak_cell_map = isolate()->factory()->weak_cell_map();
- AddStoreMapConstant(object, weak_cell_map);
-
- HInstruction* value = GetParameter(CreateWeakCellDescriptor::kValueIndex);
- Add<HStoreNamedField>(object, HObjectAccess::ForWeakCellValue(), value);
- Add<HStoreNamedField>(object, HObjectAccess::ForWeakCellNext(),
- graph()->GetConstantUndefined());
-
- HInstruction* feedback_vector =
- GetParameter(CreateWeakCellDescriptor::kVectorIndex);
- HInstruction* slot = GetParameter(CreateWeakCellDescriptor::kSlotIndex);
- Add<HStoreKeyed>(feedback_vector, slot, object, FAST_ELEMENTS,
- INITIALIZING_STORE);
- return graph()->GetConstant0();
-}
-
-
-Handle<Code> CreateWeakCellStub::GenerateCode() { return DoGenerateCode(this); }
template <>
« no previous file with comments | « src/code-stubs.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698