Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2697)

Unified Diff: content/renderer/render_view_impl.cc

Issue 886663002: Rename FocusChangeComplete to ImeShownAnimationsComplete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index dfb948d2ba5def0ba0f33140964d5ab449aefab8..2451921882ace953df04bafb6633f6ce633d7e63 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1423,7 +1423,7 @@ void RenderViewImpl::OnScrollFocusedEditableNodeIntoRect(
const gfx::Rect& rect) {
if (has_scrolled_focused_editable_node_into_rect_ &&
rect == rect_for_scrolled_focused_editable_node_) {
- FocusChangeComplete();
+ ImeShownAnimationsComplete();
return;
}
@@ -1436,7 +1436,7 @@ void RenderViewImpl::OnScrollFocusedEditableNodeIntoRect(
}
if (!will_animate)
- FocusChangeComplete();
+ ImeShownAnimationsComplete();
}
void RenderViewImpl::OnSetEditCommandsForNextKeyEvent(
@@ -3620,9 +3620,9 @@ void RenderViewImpl::GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) {
RenderWidget::GetSelectionBounds(start, end);
}
-void RenderViewImpl::FocusChangeComplete() {
- RenderWidget::FocusChangeComplete();
- FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusChangeComplete());
+void RenderViewImpl::ImeShownAnimationsComplete() {
+ RenderWidget::ImeShownAnimationsComplete();
+ FOR_EACH_OBSERVER(RenderViewObserver, observers_, ImeShownAnimationsComplete());
}
void RenderViewImpl::GetCompositionCharacterBounds(
@@ -3712,7 +3712,7 @@ void RenderViewImpl::InstrumentWillComposite() {
}
void RenderViewImpl::DidCompletePageScaleAnimation() {
- FocusChangeComplete();
+ ImeShownAnimationsComplete();
no sievers 2015/01/29 22:01:56 Also here: this is for example for double-tap zoom
please use gerrit instead 2015/01/29 22:24:24 DidCompletePageScaleAnimation is not four double-t
}
void RenderViewImpl::SetScreenMetricsEmulationParameters(
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698