Rename FocusChangeComplete to ImeShownAnimationsComplete.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 1401 matching lines @@
 
 void RenderViewImpl::OnMoveCaret(const gfx::Point& point) {
   if (!webview())
     return;
 
   Send(new InputHostMsg_MoveCaret_ACK(routing_id_));
 
   webview()->focusedFrame()->moveCaretSelection(point);
 }
 
 void RenderViewImpl::OnScrollFocusedEditableNodeIntoRect(

[no sievers, 2015/01/29 22:01:56]

Actually here it looks like (based on the generic naming of this method and the
ViewMsg and it's description) the previous name is better.

[please use gerrit instead, 2015/01/29 22:24:24]

OnScrollFocusedEditableNodeIntoRect is called in the browser after showing the
IME (virtual keyboard). The IME is shown in response to tapping an input field.
The purpose of this method is to zoom in and move the input field into legible
size above the newly shown keyboard.

     const gfx::Rect& rect) {
   if (has_scrolled_focused_editable_node_into_rect_ &&
       rect == rect_for_scrolled_focused_editable_node_) {
-    FocusChangeComplete();
+    ImeShownAnimationsComplete();
     return;
   }
 
   blink::WebElement element = GetFocusedElement();
   bool will_animate = false;
   if (!element.isNull() && IsEditableNode(element)) {
     rect_for_scrolled_focused_editable_node_ = rect;
     has_scrolled_focused_editable_node_into_rect_ = true;
     will_animate = webview()->scrollFocusedNodeIntoRect(rect);
   }
 
   if (!will_animate)
-    FocusChangeComplete();
+    ImeShownAnimationsComplete();
 }
 
 void RenderViewImpl::OnSetEditCommandsForNextKeyEvent(
     const EditCommands& edit_commands) {
   edit_commands_ = edit_commands;
 }
 
 void RenderViewImpl::OnSetHistoryOffsetAndLength(int history_offset,
                                                  int history_length) {
   DCHECK_GE(history_offset, -1);
@@ skipping 2163 matching lines @@
     // after Pepper API equips features related to surrounding text retrieval.
     gfx::Rect caret = focused_pepper_plugin_->GetCaretBounds();
     *start = caret;
     *end = caret;
     return;
   }
 #endif
   RenderWidget::GetSelectionBounds(start, end);
 }
 
-void RenderViewImpl::FocusChangeComplete() {
-  RenderWidget::FocusChangeComplete();
-  FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusChangeComplete());
+void RenderViewImpl::ImeShownAnimationsComplete() {
+  RenderWidget::ImeShownAnimationsComplete();
+  FOR_EACH_OBSERVER(RenderViewObserver, observers_, ImeShownAnimationsComplete());
 }
 
 void RenderViewImpl::GetCompositionCharacterBounds(
     std::vector<gfx::Rect>* bounds) {
   DCHECK(bounds);
   bounds->clear();
 
 #if defined(ENABLE_PLUGINS)
   if (focused_pepper_plugin_) {
     return;
@@ skipping 69 matching lines @@
 
 void RenderViewImpl::InstrumentWillComposite() {
   if (!webview())
     return;
   if (!webview()->devToolsAgent())
     return;
   webview()->devToolsAgent()->willComposite();
 }
 
 void RenderViewImpl::DidCompletePageScaleAnimation() {
-  FocusChangeComplete();
+  ImeShownAnimationsComplete();

[no sievers, 2015/01/29 22:01:56]

Also here: this is for example for double-tap zoom, right?
So why 'IMEAnimation'?

[please use gerrit instead, 2015/01/29 22:24:24]

DidCompletePageScaleAnimation is not four double-tap zoom. It's for the zoom and
scroll that happens when you tap on an input field. This animation is initiated
in webview()->scrollFocusedNodeIntoRect() on line 1435. The animation happens in
the compositor. The compositor then calls DidCompletePageScaleAnimation here.

 }
 
 void RenderViewImpl::SetScreenMetricsEmulationParameters(
     float device_scale_factor,
     const gfx::Point& root_layer_offset,
     float root_layer_scale) {
   if (webview() && compositor()) {
     webview()->setCompositorDeviceScaleFactorOverride(device_scale_factor);
     webview()->setRootLayerTransform(
         blink::WebSize(root_layer_offset.x(), root_layer_offset.y()),
@@ skipping 373 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content