Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2425)

Unified Diff: chrome/app/chrome_watcher_command_line_win.h

Issue 886613002: Introduce the ability to wait for the watcher process to initialize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_watcher_command_line_win.h
diff --git a/chrome/app/chrome_watcher_command_line_win.h b/chrome/app/chrome_watcher_command_line_win.h
index 30ff98807a0a57ea6ab30f2d69a200609e3b99ad..4b4596a7bb954416a8bf2d84070a6afb671c3ee7 100644
--- a/chrome/app/chrome_watcher_command_line_win.h
+++ b/chrome/app/chrome_watcher_command_line_win.h
@@ -15,15 +15,21 @@ class FilePath;
} // namespace base
// Generates a CommandLine that will launch |chrome_exe| in Chrome Watcher mode
-// to observe |parent_process|.
+// to observe |parent_process|. The watcher process will signal
+// |on_initialized_event| when its initialization is complete.
base::CommandLine GenerateChromeWatcherCommandLine(
const base::FilePath& chrome_exe,
- HANDLE parent_process);
+ HANDLE parent_process,
+ HANDLE on_initialized_event);
// Interprets the Command Line used to launch a Chrome Watcher process and
-// extracts the parent process HANDLE. Verifies that the handle is usable in
-// this process before returning it, and returns NULL in case of a failure.
-base::win::ScopedHandle InterpretChromeWatcherCommandLine(
- const base::CommandLine& command_line);
+// extracts the parent process and initialization event HANDLEs. Verifies that
+// the handles are usable in this process before returning them. Returns true if
+// both handles are successfully parsed and false otherwise. If only one of the
+// handles can be parsed, it will be closed.
+bool InterpretChromeWatcherCommandLine(
+ const base::CommandLine& command_line,
+ base::win::ScopedHandle* parent_process,
+ base::win::ScopedHandle* on_initialized_event);
#endif // CHROME_APP_CHROME_WATCHER_COMMAND_LINE_WIN_H_
« no previous file with comments | « chrome/app/chrome_watcher_command_line_unittest_win.cc ('k') | chrome/app/chrome_watcher_command_line_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698