Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/app/chrome_watcher_command_line_unittest_win.cc

Issue 886613002: Introduce the ability to wait for the watcher process to initialize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_watcher_client_win.cc ('k') | chrome/app/chrome_watcher_command_line_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_watcher_command_line_unittest_win.cc
diff --git a/chrome/app/chrome_watcher_command_line_unittest_win.cc b/chrome/app/chrome_watcher_command_line_unittest_win.cc
index 0cf692734b12b35b39860b5fda982bd84a64342f..771094f0c658d34cd2388e718a105414fafad0d1 100644
--- a/chrome/app/chrome_watcher_command_line_unittest_win.cc
+++ b/chrome/app/chrome_watcher_command_line_unittest_win.cc
@@ -4,6 +4,8 @@
#include "chrome/app/chrome_watcher_command_line_win.h"
+#include <windows.h>
+
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/process/process_handle.h"
@@ -11,10 +13,19 @@
#include "testing/gtest/include/gtest/gtest.h"
TEST(ChromeWatcherCommandLineTest, BasicTest) {
+ // Ownership of these handles is passed to the ScopedHandles below via
+ // InterpretChromeWatcherCommandLine().
base::ProcessHandle current = nullptr;
ASSERT_TRUE(base::OpenProcessHandle(base::GetCurrentProcId(), &current));
- base::CommandLine cmd_line =
- GenerateChromeWatcherCommandLine(base::FilePath(L"example.exe"), current);
- base::win::ScopedHandle result = InterpretChromeWatcherCommandLine(cmd_line);
- ASSERT_EQ(current, result.Get());
+ HANDLE event = ::CreateEvent(nullptr, FALSE, FALSE, nullptr);
+
+ base::CommandLine cmd_line = GenerateChromeWatcherCommandLine(
+ base::FilePath(L"example.exe"), current, event);
+
+ base::win::ScopedHandle current_result;
+ base::win::ScopedHandle event_result;
+ ASSERT_TRUE(InterpretChromeWatcherCommandLine(cmd_line, &current_result,
+ &event_result));
+ ASSERT_EQ(current, current_result.Get());
+ ASSERT_EQ(event, event_result.Get());
}
« no previous file with comments | « chrome/app/chrome_watcher_client_win.cc ('k') | chrome/app/chrome_watcher_command_line_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698