Issue 886543005: Revert of DM::SKPSrc::size() reports correct size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886543005: Revert of DM::SKPSrc::size() reports correct size. (Closed)

Created:
5 years, 10 months ago by mtklein

Modified:
5 years, 10 months ago

Reviewers:
hal.canary, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of DM::SKPSrc::size() reports correct size. (patchset #3 id:40001 of https://codereview.chromium.org/863243005/) Reason for revert: Still no good on Chrome OS bot: http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/628/steps/dm/logs/stdio Original issue's description: > DM::SKPSrc::size() reports correct size. > > Also, DM::GPUSink and DM::RasterSink crop DM::Src::size() to 2048x2048. > > Motivation: > Improve PDF testing by printing the entire SKP. > > Source: http://crrev.com/863243004 > > BUG=skia:3365 > > Committed: https://skia.googlesource.com/skia/+/441b10eac09a1f44983e35da827a6b438a409e63 > > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Release-Trybot,Test-ChromeOS-Alex-GMA3150-x86-Release-Trybot > > Committed: https://skia.googlesource.com/skia/+/d4dd58e43ca4551531ad6a9f54bfc5632ea45a80 TBR=halcanary@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3365 Committed: https://skia.googlesource.com/skia/+/f4ba3219c2d46f41f26876a14c484c4fc581286a

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -29 lines)			Patch
	M	dm/DMSrcSink.cpp	View		5 chunks	+7 lines, -21 lines	0 comments	Download
	M	gm/gm.h	View		1 chunk	+1 line, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of DM::SKPSrc::size() reports correct size.

5 years, 10 months ago (2015-01-28 23:31:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886543005/1

5 years, 10 months ago (2015-01-28 23:32:20 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-01-28 23:32:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f4ba3219c2d46f41f26876a14c484c4fc581286a