Issue 886483006: Simplify paint phase boolean logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 886483006: Simplify paint phase boolean logic. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Simplify paint phase boolean logic. Now that we only have three paint phases left, we can simplify some of it to make it more explicit that the special cases are all just for PaintPhaseMask. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a40002804fd67b4e15919d5642627ab551e4aaee

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -24 lines)			Patch
M	sky/engine/core/rendering/InlineBox.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderBlock.cpp	View	1 chunk	+3 lines, -14 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLineBoxList.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/RenderReplaced.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 10 months ago (2015-01-29 06:17:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a40002804fd67b4e15919d5642627ab551e4aaee (presubmit successful).