Simplify paint phase boolean logic.

sky/engine/core/rendering/RenderBlock.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 485 matching lines @@
 }
 
 void RenderBlock::paintChildAsInlineBlock(RenderBox* child, PaintInfo& paintInfo, const LayoutPoint& paintOffset)
 {
     if (!child->hasSelfPaintingLayer())
         paintAsInlineBlock(child, paintInfo, paintOffset);
 }
 
 void RenderBlock::paintAsInlineBlock(RenderObject* renderer, PaintInfo& paintInfo, const LayoutPoint& childPoint)
 {
-    if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhaseSelection)
+    // FIXME(sky): Why don't masks go down this path?
+    if (paintInfo.phase == PaintPhaseMask)
         return;
-
-    // Paint all phases atomically, as though the element established its own
-    // stacking context.  (See Appendix E.2, section 7.2.1.4 on
-    // inline block/table/replaced elements in the CSS2.1 specification.)
-    // This is also used by other elements (e.g. flex items).
-    PaintInfo info(paintInfo);
-
-    if (paintInfo.phase == PaintPhaseSelection) {
-        renderer->paint(info, childPoint);
-    } else {
-        info.phase = PaintPhaseForeground;
-        renderer->paint(info, childPoint);
-    }
+    renderer->paint(paintInfo, childPoint);
 }
 
 static inline bool hasCursorCaret(const FrameSelection& selection, const RenderBlock* block)
 {
     return selection.caretRenderer() == block && selection.hasEditableStyle();
 }
 
 static inline bool hasDragCaret(const DragCaretController& dragCaretController, const RenderBlock* block)
 {
     return dragCaretController.caretRenderer() == block && dragCaretController.isContentEditable();
@@ skipping 1290 matching lines @@
 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* markedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const RenderObject* obj) const
 {
     showRenderObject();
     for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRootBox())
         root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLabel2, obj, 1);
 }
 
 #endif
 
 } // namespace blink