Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 886463010: Make arguments to window.{move,resize}{To,By} non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
index 4672064d2ebd45ac964720e25f3b76f1c5eef2df..077a5f36d93b7db32601797885ef6688771f1e52 100644
--- a/Source/core/frame/DOMWindow.h
+++ b/Source/core/frame/DOMWindow.h
@@ -151,19 +151,11 @@ public:
virtual void scrollTo(const ScrollToOptions&) const = 0;
void scroll(double x, double y) const { scrollTo(x, y); }
void scroll(const ScrollToOptions& scrollToOptions) const { scrollTo(scrollToOptions); }
- void moveBy() const { moveBy(0, 0, false, false); }
- void moveBy(int x) const { moveBy(x, 0, true, false); }
- virtual void moveBy(int x, int y, bool hasX = true, bool hasY = true) const = 0;
- void moveTo() const { moveTo(0, 0, false, false); }
- void moveTo(int x) const { moveTo(x, 0, true, false); }
- virtual void moveTo(int x, int y, bool hasX = true, bool hasY = true) const = 0;
-
- void resizeBy() const { resizeBy(0, 0, false, false); }
- void resizeBy(int x) const { resizeBy(x, 0, true, false); }
- virtual void resizeBy(int x, int y, bool hasX = true, bool hasY = true) const = 0;
- void resizeTo() const { resizeTo(0, 0, false, false); }
- void resizeTo(int x) const { resizeTo(x, 0, true, false); }
- virtual void resizeTo(int width, int height, bool hasWidth = true, bool hasHeight = true) const = 0;
+ virtual void moveBy(int x, int y) const = 0;
+ virtual void moveTo(int x, int y) const = 0;
+
+ virtual void resizeBy(int x, int y) const = 0;
+ virtual void resizeTo(int width, int height) const = 0;
virtual PassRefPtrWillBeRawPtr<MediaQueryList> matchMedia(const String&) = 0;

Powered by Google App Engine
This is Rietveld 408576698