Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: Source/core/frame/DOMWindow.h

Issue 886463010: Make arguments to window.{move,resize}{To,By} non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DOMWindow_h 5 #ifndef DOMWindow_h
6 #define DOMWindow_h 6 #define DOMWindow_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/events/EventTarget.h" 9 #include "core/events/EventTarget.h"
10 #include "core/frame/DOMWindowBase64.h" 10 #include "core/frame/DOMWindowBase64.h"
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 virtual String prompt(const String& message, const String& defaultValue) = 0 ; 144 virtual String prompt(const String& message, const String& defaultValue) = 0 ;
145 145
146 virtual bool find(const String&, bool caseSensitive, bool backwards, bool wr ap, bool wholeWord, bool searchInFrames, bool showDialog) const = 0; 146 virtual bool find(const String&, bool caseSensitive, bool backwards, bool wr ap, bool wholeWord, bool searchInFrames, bool showDialog) const = 0;
147 147
148 virtual void scrollBy(double x, double y, ScrollBehavior = ScrollBehaviorAut o) const = 0; 148 virtual void scrollBy(double x, double y, ScrollBehavior = ScrollBehaviorAut o) const = 0;
149 virtual void scrollBy(const ScrollToOptions&) const = 0; 149 virtual void scrollBy(const ScrollToOptions&) const = 0;
150 virtual void scrollTo(double x, double y) const = 0; 150 virtual void scrollTo(double x, double y) const = 0;
151 virtual void scrollTo(const ScrollToOptions&) const = 0; 151 virtual void scrollTo(const ScrollToOptions&) const = 0;
152 void scroll(double x, double y) const { scrollTo(x, y); } 152 void scroll(double x, double y) const { scrollTo(x, y); }
153 void scroll(const ScrollToOptions& scrollToOptions) const { scrollTo(scrollT oOptions); } 153 void scroll(const ScrollToOptions& scrollToOptions) const { scrollTo(scrollT oOptions); }
154 void moveBy() const { moveBy(0, 0, false, false); } 154 virtual void moveBy(int x, int y) const = 0;
155 void moveBy(int x) const { moveBy(x, 0, true, false); } 155 virtual void moveTo(int x, int y) const = 0;
156 virtual void moveBy(int x, int y, bool hasX = true, bool hasY = true) const = 0;
157 void moveTo() const { moveTo(0, 0, false, false); }
158 void moveTo(int x) const { moveTo(x, 0, true, false); }
159 virtual void moveTo(int x, int y, bool hasX = true, bool hasY = true) const = 0;
160 156
161 void resizeBy() const { resizeBy(0, 0, false, false); } 157 virtual void resizeBy(int x, int y) const = 0;
162 void resizeBy(int x) const { resizeBy(x, 0, true, false); } 158 virtual void resizeTo(int width, int height) const = 0;
163 virtual void resizeBy(int x, int y, bool hasX = true, bool hasY = true) cons t = 0;
164 void resizeTo() const { resizeTo(0, 0, false, false); }
165 void resizeTo(int x) const { resizeTo(x, 0, true, false); }
166 virtual void resizeTo(int width, int height, bool hasWidth = true, bool hasH eight = true) const = 0;
167 159
168 virtual PassRefPtrWillBeRawPtr<MediaQueryList> matchMedia(const String&) = 0 ; 160 virtual PassRefPtrWillBeRawPtr<MediaQueryList> matchMedia(const String&) = 0 ;
169 161
170 // DOM Level 2 Style Interface 162 // DOM Level 2 Style Interface
171 virtual PassRefPtrWillBeRawPtr<CSSStyleDeclaration> getComputedStyle(Element *, const String& pseudoElt) const = 0; 163 virtual PassRefPtrWillBeRawPtr<CSSStyleDeclaration> getComputedStyle(Element *, const String& pseudoElt) const = 0;
172 164
173 // WebKit extensions 165 // WebKit extensions
174 virtual PassRefPtrWillBeRawPtr<CSSRuleList> getMatchedCSSRules(Element*, con st String& pseudoElt) const = 0; 166 virtual PassRefPtrWillBeRawPtr<CSSRuleList> getMatchedCSSRules(Element*, con st String& pseudoElt) const = 0;
175 167
176 // WebKit animation extensions 168 // WebKit animation extensions
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 // implementation details to scripts. 221 // implementation details to scripts.
230 bool m_windowIsClosing; 222 bool m_windowIsClosing;
231 223
232 private: 224 private:
233 mutable RefPtrWillBeMember<Location> m_location; 225 mutable RefPtrWillBeMember<Location> m_location;
234 }; 226 };
235 227
236 } // namespace blink 228 } // namespace blink
237 229
238 #endif // DOMWindow_h 230 #endif // DOMWindow_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698