SignedCertificateTimestamp storing & serialization code.

net/cert/sct_status_flags.h

Index: net/cert/sct_status_flags.h
diff --git a/net/cert/sct_status_flags.h b/net/cert/sct_status_flags.h
new file mode 100644
index 0000000000000000000000000000000000000000..6c145568911d724359036c039919cc9edc6f92b4
--- /dev/null
+++ b/net/cert/sct_status_flags.h
@@ -0,0 +1,21 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_CERT_SCT_STATUS_H_
+#define NET_CERT_SCT_STATUS_H_
+
+namespace net {
+
+typedef uint16 SignedCertificateTimestampVerificationStatus;
+
+const SignedCertificateTimestampVerificationStatus kSctStatusAll = 0x0003;

[Eran M. (Google), 2013/11/26 21:33:22]

You may be able to use values I defined in the other patch, see:
https://codereview.chromium.org/76443006/diff/260001/net/cert/cert_status_fla...

Or that may be frowned upon, worth pointing out to the reviewers either way.

[alcutter, 2013/11/26 23:00:05]

Could you give your enum a type name ?

+const SignedCertificateTimestampVerificationStatus kSctStatusOk = 0x0000;

[Eran M. (Google), 2013/11/26 21:33:22]

Nit: I'd suggest having the OK status as non-zero, so a
SignedCertificateTimestampVerificationStatus instance that has just been created
and initialized to 0 will indicate absence of SCTs, rather than OK verification.

[alcutter, 2013/11/26 23:00:05]

This was actually a bit-field, which is why zero was OK, but looking back this
is probably overkill so I've changed to an enum.

+
+const SignedCertificateTimestampVerificationStatus kSctStatusInvalid = 1 << 0;
+const SignedCertificateTimestampVerificationStatus kSctStatusLogUnknown = 1
+                                                                          << 1;
+
+}  // namespace net
+
+#endif  // NET_CERT_SCT_STATUS_H_