net/cert/sct_status_flags.h - Issue 88643002: SignedCertificateTimestamp storing & serialization code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/sct_status_flags.h

Issue 88643002: SignedCertificateTimestamp storing & serialization code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erans_patches

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_CERT_SCT_STATUS_H_

	6 #define NET_CERT_SCT_STATUS_H_

	7

	8 namespace net {

	9

	10 typedef uint16 SignedCertificateTimestampVerificationStatus;

	11

	12 const SignedCertificateTimestampVerificationStatus kSctStatusAll = 0x0003;
	Eran M. (Google) 2013/11/26 21:33:22 You may be able to use values I defined in the oth You may be able to use values I defined in the other patch, see: https://codereview.chromium.org/76443006/diff/260001/net/cert/cert_status_fla... Or that may be frowned upon, worth pointing out to the reviewers either way. alcutter 2013/11/26 23:00:05 Could you give your enum a type name ? Show quoted text On 2013/11/26 21:33:22, eranm wrote: > You may be able to use values I defined in the other patch, see: > https://codereview.chromium.org/76443006/diff/260001/net/cert/cert_status_fla... > > Or that may be frowned upon, worth pointing out to the reviewers either way. Could you give your enum a type name ?
	13 const SignedCertificateTimestampVerificationStatus kSctStatusOk = 0x0000;
	Eran M. (Google) 2013/11/26 21:33:22 Nit: I'd suggest having the OK status as non-zero, Nit: I'd suggest having the OK status as non-zero, so a SignedCertificateTimestampVerificationStatus instance that has just been created and initialized to 0 will indicate absence of SCTs, rather than OK verification. alcutter 2013/11/26 23:00:05 This was actually a bit-field, which is why zero w Show quoted text On 2013/11/26 21:33:22, eranm wrote: > Nit: I'd suggest having the OK status as non-zero, so a > SignedCertificateTimestampVerificationStatus instance that has just been created > and initialized to 0 will indicate absence of SCTs, rather than OK verification. This was actually a bit-field, which is why zero was OK, but looking back this is probably overkill so I've changed to an enum.
	14

	15 const SignedCertificateTimestampVerificationStatus kSctStatusInvalid = 1 << 0;

	16 const SignedCertificateTimestampVerificationStatus kSctStatusLogUnknown = 1

	17 << 1;

	18

	19 } // namespace net

	20

	21 #endif // NET_CERT_SCT_STATUS_H_

OLD	NEW