Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 886323002: Remove more targets from GN Windows build. (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
dpranke
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mlamouri+watch-content_chromium.org, sadrul, extensions-reviews_chromium.org, peter+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, jam, piman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, cc-bugs_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove more targets from GN Windows build. Targets will be removed until the bot is green. TBR=dpranke Committed: https://crrev.com/6aa1895622f98deaed0943be3c8f02a53e563a50 Cr-Commit-Position: refs/heads/master@{#314104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -793 lines) Patch
M ash/BUILD.gn View 1 chunk +36 lines, -34 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +151 lines, -149 lines 0 comments Download
M chrome/test/perf/BUILD.gn View 1 chunk +23 lines, -18 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/BUILD.gn View 1 chunk +37 lines, -35 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +199 lines, -197 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +59 lines, -57 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +51 lines, -49 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +26 lines, -24 lines 0 comments Download
M ui/message_center/BUILD.gn View 1 chunk +56 lines, -54 lines 0 comments Download
M ui/snapshot/BUILD.gn View 1 chunk +29 lines, -27 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +89 lines, -87 lines 0 comments Download
M ui/views/examples/BUILD.gn View 1 chunk +29 lines, -27 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +34 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
brettw
5 years, 10 months ago (2015-02-02 04:33:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/886323002/1
5 years, 10 months ago (2015-02-02 04:34:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 05:34:54 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 05:35:43 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6aa1895622f98deaed0943be3c8f02a53e563a50
Cr-Commit-Position: refs/heads/master@{#314104}

Powered by Google App Engine
This is Rietveld 408576698