Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2028)

Unified Diff: ui/message_center/BUILD.gn

Issue 886323002: Remove more targets from GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/keyboard/BUILD.gn ('k') | ui/snapshot/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/BUILD.gn
diff --git a/ui/message_center/BUILD.gn b/ui/message_center/BUILD.gn
index 2a4e64318d4ce25712fe3cf923b6a2a905213c63..4c2b57c047ec084b5bcb6d0dcdaf77bd9a93dbe2 100644
--- a/ui/message_center/BUILD.gn
+++ b/ui/message_center/BUILD.gn
@@ -175,63 +175,65 @@ static_library("test_support") {
]
}
-test("message_center_unittests") {
- sources = [
- "test/run_all_unittests.cc",
- ]
-
- deps = [
- ":message_center",
- ":test_support",
- "//base",
- "//base/allocator",
- "//base/test:test_support",
- "//skia",
- "//testing/gtest",
- "//ui/base",
- "//ui/events",
- "//ui/gfx",
- "//ui/gfx/geometry",
- "//ui/gl",
- "//ui/resources",
- "//ui/resources:ui_test_pak",
- "//url",
- ]
-
- if (enable_notifications && !is_android) {
- sources += [
- "cocoa/notification_controller_unittest.mm",
- "cocoa/popup_collection_unittest.mm",
- "cocoa/popup_controller_unittest.mm",
- "cocoa/settings_controller_unittest.mm",
- "cocoa/status_item_view_unittest.mm",
- "cocoa/tray_controller_unittest.mm",
- "cocoa/tray_view_controller_unittest.mm",
- "message_center_tray_unittest.cc",
- "message_center_impl_unittest.cc",
- "notification_delegate_unittest.cc",
- "notification_list_unittest.cc",
+if (!is_win || link_chrome_on_windows) {
+ test("message_center_unittests") {
+ sources = [
+ "test/run_all_unittests.cc",
]
- if (is_mac) {
- deps += [ "//ui/gfx:test_support" ]
- }
+ deps = [
+ ":message_center",
+ ":test_support",
+ "//base",
+ "//base/allocator",
+ "//base/test:test_support",
+ "//skia",
+ "//testing/gtest",
+ "//ui/base",
+ "//ui/events",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ "//ui/gl",
+ "//ui/resources",
+ "//ui/resources:ui_test_pak",
+ "//url",
+ ]
- if (toolkit_views && !is_mac) {
+ if (enable_notifications && !is_android) {
sources += [
- "views/bounded_label_unittest.cc",
- "views/message_center_view_unittest.cc",
- "views/message_popup_collection_unittest.cc",
- "views/notification_view_unittest.cc",
- "views/notifier_settings_view_unittest.cc",
+ "cocoa/notification_controller_unittest.mm",
+ "cocoa/popup_collection_unittest.mm",
+ "cocoa/popup_controller_unittest.mm",
+ "cocoa/settings_controller_unittest.mm",
+ "cocoa/status_item_view_unittest.mm",
+ "cocoa/tray_controller_unittest.mm",
+ "cocoa/tray_view_controller_unittest.mm",
+ "message_center_tray_unittest.cc",
+ "message_center_impl_unittest.cc",
+ "notification_delegate_unittest.cc",
+ "notification_list_unittest.cc",
]
- deps += [
- # Compositor is needed by message_center_view_unittest.cc and for the
- # fonts used by bounded_label_unittest.cc.
- "//ui/compositor",
- "//ui/views",
- "//ui/views:test_support",
- ]
- }
- } # enable_notifications && !is_android
+
+ if (is_mac) {
+ deps += [ "//ui/gfx:test_support" ]
+ }
+
+ if (toolkit_views && !is_mac) {
+ sources += [
+ "views/bounded_label_unittest.cc",
+ "views/message_center_view_unittest.cc",
+ "views/message_popup_collection_unittest.cc",
+ "views/notification_view_unittest.cc",
+ "views/notifier_settings_view_unittest.cc",
+ ]
+ deps += [
+ # Compositor is needed by message_center_view_unittest.cc and for the
+ # fonts used by bounded_label_unittest.cc.
+ "//ui/compositor",
+ "//ui/views",
+ "//ui/views:test_support",
+ ]
+ }
+ } # enable_notifications && !is_android
+ }
}
« no previous file with comments | « ui/keyboard/BUILD.gn ('k') | ui/snapshot/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698