runtime/vm/assembler_arm_test.cc - Issue 886173003: VM: Align implementations of assembler constant pools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm_test.cc

Issue 886173003: VM: Align implementations of assembler constant pools. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed ARM debug assert Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm_test.cc

===================================================================

--- runtime/vm/assembler_arm_test.cc (revision 43497)

+++ runtime/vm/assembler_arm_test.cc (working copy)

@@ -62,13 +62,13 @@

#if defined(USING_SIMULATOR)

// ARMv7 is the default.

HostCPUFeatures::set_arm_version(ARMv6);

- __ LoadDecodableImmediate(R0, 0x12345678 << 1);

+ __ LoadPatchableImmediate(R0, 0x12345678 << 1);

HostCPUFeatures::set_arm_version(ARMv7);

- __ LoadDecodableImmediate(R1, 0x12345678);

+ __ LoadPatchableImmediate(R1, 0x12345678);

__ sub(R0, R0, Operand(R1));

__ bx(LR);

#else

- __ LoadDecodableImmediate(R0, 0x12345678);

+ __ LoadPatchableImmediate(R0, 0x12345678);

__ bx(LR);

#endif

}

« runtime/vm/assembler_arm64.cc ('K') | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_mips.h » ('j') | no next file with comments »