chromecast/browser/metrics/cast_metrics_service_client.h - Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed GN build Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index af71a1ca1118f5e855344db12cd75f40f001643c..72ceedef9520907ac9aff2bc9215f2153dd0e111 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -61,8 +61,6 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

void StartGatheringMetrics(const base::Closure& done_callback) override;

void CollectFinalMetrics(const base::Closure& done_callback) override;

scoped_ptr< ::metrics::MetricsLogUploader> CreateUploader(

- const std::string& server_url,

- const std::string& mime_type,

const base::Callback<void(int)>& on_upload_complete) override;

// Starts/stops the metrics service.