Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 886173002: Allow server endpoint to be injected into the NetMetricsLogUploader from chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed GN build Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/metrics/cast_metrics_service_client.h ('k') | components/metrics.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/metrics/cast_metrics_service_client.cc
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc
index 84192d7a5acc472c1818f279eb1658499db39115..3e97217bea0c348aef93cb71cce49ad69296cd1d 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.cc
+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc
@@ -21,6 +21,7 @@
#include "components/metrics/net/net_metrics_log_uploader.h"
#include "components/metrics/net/network_metrics_provider.h"
#include "components/metrics/profiler/profiler_metrics_provider.h"
+#include "components/metrics/url_constants.h"
#include "content/public/common/content_switches.h"
#if defined(OS_LINUX)
@@ -133,10 +134,8 @@ void CastMetricsServiceClient::CollectFinalMetrics(
scoped_ptr< ::metrics::MetricsLogUploader>
CastMetricsServiceClient::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
const base::Callback<void(int)>& on_upload_complete) {
- std::string uma_server_url(server_url);
+ std::string uma_server_url(::metrics::kDefaultMetricsServerUrl);
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
if (command_line->HasSwitch(switches::kOverrideMetricsUploadUrl)) {
uma_server_url.assign(
@@ -147,7 +146,7 @@ CastMetricsServiceClient::CreateUploader(
new ::metrics::NetMetricsLogUploader(
request_context_,
uma_server_url,
- mime_type,
+ ::metrics::kDefaultMetricsMimeType,
on_upload_complete));
}
« no previous file with comments | « chromecast/browser/metrics/cast_metrics_service_client.h ('k') | components/metrics.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698