Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 885973002: Disable PDFBrowserTest.Scroll on Chrome OS (Closed)

Created:
5 years, 10 months ago by James Cook
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PDFBrowserTest.Scroll on Chrome OS It fails on the official builders. BUG=446221 TEST=none TBR=thestig@chromium.org NOTRY=true Committed: https://crrev.com/337db9a37656c022d52aa47c661ab757dce32bc3 Cr-Commit-Position: refs/heads/master@{#313829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885973002/1
5 years, 10 months ago (2015-01-29 23:45:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 23:47:06 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/337db9a37656c022d52aa47c661ab757dce32bc3 Cr-Commit-Position: refs/heads/master@{#313829}
5 years, 10 months ago (2015-01-29 23:47:54 UTC) #4
Lei Zhang
Sure, I'll try to figure these out.
5 years, 10 months ago (2015-01-29 23:54:05 UTC) #6
Lei Zhang
Err, lgtm
5 years, 10 months ago (2015-01-29 23:54:13 UTC) #7
James Cook
5 years, 10 months ago (2015-01-29 23:55:38 UTC) #8
Message was sent while issue was closed.
On 2015/01/29 23:54:13, Lei Zhang wrote:
> Err, lgtm

piman was looking over my shoulder and thought there might be a race between the
compositor thread (handling the mouse wheel event? not sure) and JavaScript
execution to fetch the scroll position.

Powered by Google App Engine
This is Rietveld 408576698