Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/ui/pdf/pdf_browsertest.cc

Issue 885973002: Disable PDFBrowserTest.Scroll on Chrome OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/pdf/pdf_browsertest.cc
diff --git a/chrome/browser/ui/pdf/pdf_browsertest.cc b/chrome/browser/ui/pdf/pdf_browsertest.cc
index 4e82b3340619808d0aa1b9564410980a5191e064..2f099df23471845fad553b7ff33ee36578c67b96 100644
--- a/chrome/browser/ui/pdf/pdf_browsertest.cc
+++ b/chrome/browser/ui/pdf/pdf_browsertest.cc
@@ -47,10 +47,14 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Basic) {
#endif
}
-#if defined(GOOGLE_CHROME_BUILD) && (defined(OS_WIN) || defined(OS_LINUX))
+#if defined(GOOGLE_CHROME_BUILD) && \
+ (defined(OS_WIN) || (defined(OS_LINUX) && !defined(OS_CHROMEOS)))
#define MAYBE_Scroll Scroll
#else
-// TODO(thestig): http://crbug.com/79837, http://crbug.com/332778
+// TODO(thestig): http://crbug.com/79837, http://crbug.com/332778,
+// http://crbug.com/446221 Possibly a race between mouse event processing and
+// JavaScript execution in the renderer. The failure goes away if you Sleep()
+// after SwapBuffers.
#define MAYBE_Scroll DISABLED_Scroll
#endif
// Tests that scrolling works.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698