Issue 885673002: dart2js: Address comments from CL 871073002.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 885673002: dart2js: Address comments from CL 871073002. (Closed)

Created:
5 years, 10 months ago by floitsch

Modified:
5 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/program_builder.dart	View		1 chunk	+7 lines, -12 lines	0 comments	Download
	M	pkg/dart2js_incremental/lib/library_updater.dart	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

floitsch

TBR. (Since this CL addresses comments that were LGTMed).

5 years, 10 months ago (2015-01-28 16:24:52 UTC) #2

floitsch

5 years, 10 months ago (2015-01-28 16:25:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43245 (presubmit successful).