Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Side by Side Diff: pkg/dart2js_incremental/lib/library_updater.dart

Issue 885673002: dart2js: Address comments from CL 871073002. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js_incremental.library_updater; 5 library dart2js_incremental.library_updater;
6 6
7 import 'dart:async' show 7 import 'dart:async' show
8 Future; 8 Future;
9 9
10 import 'dart:convert' show 10 import 'dart:convert' show
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 import 'package:compiler/src/js_emitter/js_emitter.dart' show 61 import 'package:compiler/src/js_emitter/js_emitter.dart' show
62 ClassBuilder, 62 ClassBuilder,
63 ClassEmitter, 63 ClassEmitter,
64 CodeEmitterTask, 64 CodeEmitterTask,
65 ContainerBuilder, 65 ContainerBuilder,
66 MemberInfo, 66 MemberInfo,
67 computeMixinClass; 67 computeMixinClass;
68 68
69 import 'package:compiler/src/js_emitter/model.dart' show 69 import 'package:compiler/src/js_emitter/model.dart' show
70 Class; 70 Class;
71
71 import 'package:compiler/src/js_emitter/program_builder.dart' show 72 import 'package:compiler/src/js_emitter/program_builder.dart' show
72 ProgramBuilder; 73 ProgramBuilder;
73 74
74 import 'package:_internal/compiler/js_lib/shared/embedded_names.dart' 75 import 'package:_internal/compiler/js_lib/shared/embedded_names.dart'
75 as embeddedNames; 76 as embeddedNames;
76 77
77 import 'package:compiler/src/js_backend/js_backend.dart' show 78 import 'package:compiler/src/js_backend/js_backend.dart' show
78 JavaScriptBackend, 79 JavaScriptBackend,
79 Namer; 80 Namer;
80 81
(...skipping 1387 matching lines...) Expand 10 before | Expand all | Expand 10 after
1468 1469
1469 class EmitterHelper extends JsFeatures { 1470 class EmitterHelper extends JsFeatures {
1470 final Compiler compiler; 1471 final Compiler compiler;
1471 1472
1472 EmitterHelper(this.compiler); 1473 EmitterHelper(this.compiler);
1473 1474
1474 ClassEmitter get classEmitter => backend.emitter.oldEmitter.classEmitter; 1475 ClassEmitter get classEmitter => backend.emitter.oldEmitter.classEmitter;
1475 1476
1476 List<String> computeFields(ClassElement classElement) { 1477 List<String> computeFields(ClassElement classElement) {
1477 Class cls = new ProgramBuilder(compiler, namer, emitter) 1478 Class cls = new ProgramBuilder(compiler, namer, emitter)
1478 .buildClassWithFieldsForTry(classElement); 1479 .buildClassWithFieldsForIncrementalCompilation(classElement);
1479 // TODO(ahe): Rewrite for new emitter. 1480 // TODO(ahe): Rewrite for new emitter.
1480 ClassBuilder builder = new ClassBuilder(classElement, namer); 1481 ClassBuilder builder = new ClassBuilder(classElement, namer);
1481 classEmitter.emitFields(cls, builder); 1482 classEmitter.emitFields(cls, builder);
1482 return builder.fields; 1483 return builder.fields;
1483 } 1484 }
1484 } 1485 }
1485 1486
1486 // TODO(ahe): Remove this method. 1487 // TODO(ahe): Remove this method.
1487 NO_WARN(x) => x; 1488 NO_WARN(x) => x;
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698