Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 885563002: Fix a crash in MimeHandlerServiceImpl::AbortStream(). (Closed)

Created:
5 years, 11 months ago by Sam McNally
Modified:
5 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash in MimeHandlerServiceImpl::AbortStream(). BUG=452799 Committed: https://crrev.com/1cd6baf6813f91375098d1b74016575d2b135e33 Cr-Commit-Position: refs/heads/master@{#313472}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -1 line) Patch
M extensions/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc View 1 1 chunk +106 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/extensions_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Sam McNally
5 years, 11 months ago (2015-01-28 05:18:28 UTC) #2
benwells
On 2015/01/28 05:18:28, Sam McNally wrote: Is there a bug logged for this? I'm wondering ...
5 years, 11 months ago (2015-01-28 05:22:01 UTC) #3
Sam McNally
On 2015/01/28 05:22:01, benwells wrote: > On 2015/01/28 05:18:28, Sam McNally wrote: > > Is ...
5 years, 11 months ago (2015-01-28 06:40:00 UTC) #4
benwells
On 2015/01/28 06:40:00, Sam McNally wrote: > On 2015/01/28 05:22:01, benwells wrote: > > On ...
5 years, 11 months ago (2015-01-28 07:08:35 UTC) #5
Sam McNally
On 2015/01/28 07:08:35, benwells wrote: > On 2015/01/28 06:40:00, Sam McNally wrote: > > On ...
5 years, 11 months ago (2015-01-28 07:17:40 UTC) #6
benwells
lgtm
5 years, 11 months ago (2015-01-28 07:54:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885563002/20002
5 years, 11 months ago (2015-01-28 09:27:49 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:20002)
5 years, 11 months ago (2015-01-28 10:16:37 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 10:17:47 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1cd6baf6813f91375098d1b74016575d2b135e33
Cr-Commit-Position: refs/heads/master@{#313472}

Powered by Google App Engine
This is Rietveld 408576698