extensions/browser/api/mime_handler_private/mime_handler_private.cc - Issue 885563002: Fix a crash in MimeHandlerServiceImpl::AbortStream().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/mime_handler_private/mime_handler_private.cc

Issue 885563002: Fix a crash in MimeHandlerServiceImpl::AbortStream(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: GN Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/mime_handler_private/mime_handler_private.h ('k') | extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/mime_handler_private/mime_handler_private.cc

diff --git a/extensions/browser/api/mime_handler_private/mime_handler_private.cc b/extensions/browser/api/mime_handler_private/mime_handler_private.cc

index e2a25b1a3281ca88ee93c392679b231b2bcb4354..b7d557d18015285cb3bb90a542fb863dfdf0bfaa 100644

--- a/extensions/browser/api/mime_handler_private/mime_handler_private.cc

+++ b/extensions/browser/api/mime_handler_private/mime_handler_private.cc

@@ -60,6 +60,10 @@ void MimeHandlerServiceImpl::GetStreamInfo(

void MimeHandlerServiceImpl::AbortStream(

const mojo::Callback<void()>& callback) {

+ if (!stream_) {

+ callback.Run();

+ return;

+ }

stream_->Abort(base::Bind(&MimeHandlerServiceImpl::OnStreamClosed,

weak_factory_.GetWeakPtr(), callback));

}