extensions/renderer/programmatic_script_injector.h - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/programmatic_script_injector.h

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Host::IsEmpty() and move ExtensionConsumer to extensions/renderer. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/extension_consumer.cc ('K') | « extensions/renderer/extension_consumer.cc ('k') | extensions/renderer/programmatic_script_injector.cc » ('j') | extensions/renderer/programmatic_script_injector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/programmatic_script_injector.h

diff --git a/extensions/renderer/programmatic_script_injector.h b/extensions/renderer/programmatic_script_injector.h

index ef5420a5e006294fad620adbb8775da25c55fa87..670a26b337b1163162c5890c4a91189a5ebb9c12 100644

--- a/extensions/renderer/programmatic_script_injector.h

+++ b/extensions/renderer/programmatic_script_injector.h

@@ -40,7 +40,7 @@ class ProgrammaticScriptInjector : public ScriptInjector {

bool ShouldInjectJs(UserScript::RunLocation run_location) const override;

bool ShouldInjectCss(UserScript::RunLocation run_location) const override;

PermissionsData::AccessType CanExecuteOnFrame(

- const Extension* extension,

+ const Host* host,

blink::WebFrame* web_frame,

int tab_id,

const GURL& top_url) const override;