Refactoring: de-couple Extensions from "script injection System" [render side] : 1

extensions/renderer/programmatic_script_injector.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_
 #define EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "extensions/renderer/script_injection.h"
 #include "url/gurl.h"
 
 struct ExtensionMsg_ExecuteCode_Params;
 
 namespace blink {
 class WebFrame;
 }
 
 namespace content {
 class RenderView;
 }
 
 namespace extensions {
 class Extension;

[Devlin, 2015/02/09 17:40:24]

Shouldn't need this.

[Xi Han, 2015/02/09 23:28:11]

Removed.

 
 // A ScriptInjector to handle tabs.executeScript().
 class ProgrammaticScriptInjector : public ScriptInjector {
  public:
   ProgrammaticScriptInjector(const ExtensionMsg_ExecuteCode_Params& params,
                              blink::WebFrame* web_frame);
   ~ProgrammaticScriptInjector() override;
 
  private:
   // ScriptInjector implementation.
   UserScript::InjectionType script_type() const override;
   bool ShouldExecuteInChildFrames() const override;
   bool ShouldExecuteInMainWorld() const override;
   bool IsUserGesture() const override;
   bool ExpectsResults() const override;
   bool ShouldInjectJs(UserScript::RunLocation run_location) const override;
   bool ShouldInjectCss(UserScript::RunLocation run_location) const override;
   PermissionsData::AccessType CanExecuteOnFrame(
-      const Extension* extension,
+      const Host* host,
       blink::WebFrame* web_frame,
       int tab_id,
       const GURL& top_url) const override;
   std::vector<blink::WebScriptSource> GetJsSources(
       UserScript::RunLocation run_location) const override;
   std::vector<std::string> GetCssSources(
       UserScript::RunLocation run_location) const override;
   void OnInjectionComplete(scoped_ptr<base::ListValue> execution_results,
                            ScriptsRunInfo* scripts_run_info,
                            UserScript::RunLocation run_location) override;
@@ skipping 20 matching lines @@
 
   // Whether or not this script injection has finished.
   bool finished_;
 
   DISALLOW_COPY_AND_ASSIGN(ProgrammaticScriptInjector);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_PROGRAMMATIC_SCRIPT_INJECTOR_H_