Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Devlin@'s comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index 4816da7e0687d8ce20a9b3f0af4717c47edc2252..32dcf05326d24b1197ed93c73955a5c2b26ec2c0 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -75,6 +75,7 @@
#include "extensions/common/constants.h"
#include "extensions/common/error_utils.h"
#include "extensions/common/extension.h"
+#include "extensions/common/host_id.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handlers/default_locale_handler.h"
#include "extensions/common/message_bundle.h"
@@ -1250,6 +1251,7 @@ bool TabsUpdateFunction::UpdateURL(const std::string &url_string,
ScriptExecutor::MAIN_WORLD,
ScriptExecutor::DEFAULT_PROCESS,
GURL(),
+ Host::kDefaultInstanceId,
GURL(),
user_gesture_,
ScriptExecutor::NO_RESULT,
@@ -1797,6 +1799,10 @@ const GURL& ExecuteCodeInTabFunction::GetWebViewSrc() const {
return GURL::EmptyGURL();
}
+int ExecuteCodeInTabFunction::GetScriptInjectionInstanceId() const {
+ return Host::kDefaultInstanceId;
+}
+
bool TabsExecuteScriptFunction::ShouldInsertCSS() const {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698