extensions/browser/api/web_view/web_view_internal_api.h - Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_view/web_view_internal_api.h

Issue 885493007: Refactoring: de-couple Extensions from "script injection System" [render side] : 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Devlin@'s comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/api/web_view/web_view_internal_api.cc » ('j') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_view/web_view_internal_api.h

diff --git a/extensions/browser/api/web_view/web_view_internal_api.h b/extensions/browser/api/web_view/web_view_internal_api.h

index ad66ed28ba97af15cdfa76cdc844bc8f44d8b102..04b235997161a1e7acea77bed2dfee433db4a089 100644

--- a/extensions/browser/api/web_view/web_view_internal_api.h

+++ b/extensions/browser/api/web_view/web_view_internal_api.h

@@ -66,6 +66,7 @@ class WebViewInternalExecuteCodeFunction

extensions::ScriptExecutor* GetScriptExecutor() final;

bool IsWebView() const override;

const GURL& GetWebViewSrc() const override;

+ int GetScriptInjectionInstanceId() const override;

private:

// Contains extension resource built from path of file which is

@@ -76,6 +77,8 @@ class WebViewInternalExecuteCodeFunction

GURL guest_src_;

+ int script_injection_instance_id_;

Devlin 2015/02/06 00:28:41 You need to initialize this in the constructor.

Xi Han 2015/02/06 17:21:45 Done.

DISALLOW_COPY_AND_ASSIGN(WebViewInternalExecuteCodeFunction);

};