DM: some refactoring

dm/DMChecksumTask.h

Index: dm/DMChecksumTask.h
diff --git a/dm/DMComparisonTask.h b/dm/DMChecksumTask.h
similarity index 57%
rename from dm/DMComparisonTask.h
rename to dm/DMChecksumTask.h
index 265a58ce325c4256878c89427fc30eb3e5424369..b0afac9467be2365e20ffb854a8cf010af1535b6 100644
--- a/dm/DMComparisonTask.h
+++ b/dm/DMChecksumTask.h
@@ -1,5 +1,5 @@
-#ifndef DMComparisonTask_DEFINED
-#define DMComparisonTask_DEFINED
+#ifndef DMChecksumTask_DEFINED
+#define DMChecksumTask_DEFINED
 
 #include "DMTask.h"
 #include "SkBitmap.h"
@@ -8,12 +8,11 @@
 
 namespace DM {
 
-// We use ComparisonTask to move CPU-bound comparison work of GpuTasks back to
-// the main thread pool, where we probably have more threads available.
-
-class ComparisonTask : public Task {
+// ChecksumTask compares an SkBitmap against some Expectations.
+// Moving this off the GPU threadpool is a nice (~30%) runtime win.
+class ChecksumTask : public Task {

[epoger, 2013/11/26 17:55:22]

Not a big deal either way, but IMO "ComparisonTask" is still more descriptive
(based on the description above, and the arguments passed into the constructor)

[mtklein, 2013/11/26 18:25:30]

Yeah, wanted something to make it distinct from the other bitmap-to-bitmap
comparison tasks (replay, pipe, etc.)

 public:
-    ComparisonTask(const Task& parent, skiagm::Expectations, SkBitmap);
+    ChecksumTask(const Task& parent, skiagm::Expectations, SkBitmap);
 
     virtual void draw() SK_OVERRIDE;
     virtual bool usesGpu() const SK_OVERRIDE { return false; }
@@ -28,4 +27,4 @@ private:
 
 }  // namespace DM
 
-#endif  // DMComparisonTask_DEFINED
+#endif  // DMChecksumTask_DEFINED