Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Unified Diff: tools/gn/action_target_generator.cc

Issue 885283006: gn: Allow users to set 'check_includes' in action_foreach(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/action_target_generator.h ('K') | « tools/gn/action_target_generator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/action_target_generator.cc
diff --git a/tools/gn/action_target_generator.cc b/tools/gn/action_target_generator.cc
index 09c89e4ca949b5c36e11b883ef665a6b5297351c..933767e8174a819a3cfe79cdb8153ae70fbc5b8f 100644
--- a/tools/gn/action_target_generator.cc
+++ b/tools/gn/action_target_generator.cc
@@ -54,6 +54,9 @@ void ActionTargetGenerator::DoRun() {
if (!FillDepfile())
return;
+ if (!FillCheckIncludes())
+ return;
+
if (!CheckOutputs())
return;
@@ -105,6 +108,16 @@ bool ActionTargetGenerator::FillDepfile() {
return true;
}
+bool ActionTargetGenerator::FillCheckIncludes() {
brettw 2015/01/30 23:08:55 To avoid duplication with the binary target genera
tfarina 2015/01/30 23:18:29 Done.
+ const Value* value = scope_->GetValue(variables::kCheckIncludes, true);
+ if (!value)
+ return true;
+ if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
+ return false;
+ target_->set_check_includes(value->boolean_value());
+ return true;
+}
+
bool ActionTargetGenerator::CheckOutputs() {
const SubstitutionList& outputs = target_->action_values().outputs();
if (outputs.list().empty()) {
« tools/gn/action_target_generator.h ('K') | « tools/gn/action_target_generator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698