gn: Allow users to set 'check_includes' in action_foreach().

tools/gn/action_target_generator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/action_target_generator.h"
 
 #include "tools/gn/build_settings.h"
 #include "tools/gn/err.h"
 #include "tools/gn/filesystem_utils.h"
 #include "tools/gn/parse_tree.h"
@@ skipping 36 matching lines @@
 
   if (!FillScriptArgs())
     return;
 
   if (!FillOutputs(output_type_ == Target::ACTION_FOREACH))
     return;
 
   if (!FillDepfile())
     return;
 
+  if (!FillCheckIncludes())
+    return;
+
   if (!CheckOutputs())
     return;
 
   // Action outputs don't depend on the current toolchain so we can skip adding
   // that dependency.
 }
 
 bool ActionTargetGenerator::FillScript() {
   // If this gets called, the target type requires a script, so error out
   // if it doesn't have one.
@@ skipping 31 matching lines @@
   SubstitutionPattern depfile;
   if (!depfile.Parse(*value, err_))
     return false;
   if (!EnsureSubstitutionIsInOutputDir(depfile, *value))
     return false;
 
   target_->action_values().set_depfile(depfile);
   return true;
 }
 
+bool ActionTargetGenerator::FillCheckIncludes() {

[brettw, 2015/01/30 23:08:55]

To avoid duplication with the binary target generator, can you move this to
TargetGenerator. Then the different specializations can call it when
appropriate.

[tfarina, 2015/01/30 23:18:29]

Done.

+  const Value* value = scope_->GetValue(variables::kCheckIncludes, true);
+  if (!value)
+    return true;
+  if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
+    return false;
+  target_->set_check_includes(value->boolean_value());
+  return true;
+}
+
 bool ActionTargetGenerator::CheckOutputs() {
   const SubstitutionList& outputs = target_->action_values().outputs();
   if (outputs.list().empty()) {
     *err_ = Err(function_call_, "Action has no outputs.",
         "If you have no outputs, the build system can not tell when your\n"
         "script needs to be run.");
     return false;
   }
 
   if (output_type_ == Target::ACTION) {
@@ skipping 10 matching lines @@
       *err_ = Err(function_call_,
           "action_foreach should have a pattern in the output.",
           "An action_foreach target should have a source expansion pattern in\n"
           "it to map source file to unique output file name. Otherwise, the\n"
           "build system can't determine when your script needs to be run.");
       return false;
     }
   }
   return true;
 }