Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 885243002: Implement parsing of ES6 Rest Parameters (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement parsing of ES6 Rest Parameters BUG=v8:2159 LOG=N R=marja@chromium.org, arv@chromium.org Committed: https://crrev.com/9355457b556586cfbbee8051aa186eee0eb0dae3 Cr-Commit-Position: refs/heads/master@{#26362}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix DCHECK_EQ() in scopes.cc #

Patch Set 3 : ...fixit again #

Patch Set 4 : [parsing]: eval/arguments parameter names are ok in sloppy mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -4 lines) Patch
M src/parser.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 3 chunks +104 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
caitp (gmail)
PTAL at your leisure... Parsing cut out from for https://crrev.com/816913003/
5 years, 10 months ago (2015-01-30 04:35:59 UTC) #1
arv (Not doing code reviews)
I know it was probably intended as a joke but please change the CL description ...
5 years, 10 months ago (2015-01-30 05:28:13 UTC) #3
marja
lgtm https://codereview.chromium.org/885243002/diff/1/src/scanner.cc File src/scanner.cc (right): https://codereview.chromium.org/885243002/diff/1/src/scanner.cc#newcode602 src/scanner.cc:602: if (c0_ == '.') { Maybe that's a ...
5 years, 10 months ago (2015-01-30 08:33:31 UTC) #4
caitp (gmail)
On 2015/01/30 05:28:13, arv wrote: > I know it was probably intended as a joke ...
5 years, 10 months ago (2015-01-30 14:14:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885243002/1
5 years, 10 months ago (2015-01-30 14:17:05 UTC) #7
marja
The description is a bit unintentionally funny now: "Implement parsing of 6 Rest Parameters" :)
5 years, 10 months ago (2015-01-30 14:22:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2470)
5 years, 10 months ago (2015-01-30 14:23:40 UTC) #10
caitp (gmail)
On 2015/01/30 14:22:24, marja wrote: > The description is a bit unintentionally funny now: "Implement ...
5 years, 10 months ago (2015-01-30 14:24:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885243002/20001
5 years, 10 months ago (2015-01-30 14:28:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885243002/40001
5 years, 10 months ago (2015-01-30 14:41:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-30 15:21:47 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 15:22:02 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/9355457b556586cfbbee8051aa186eee0eb0dae3
Cr-Commit-Position: refs/heads/master@{#26362}

Powered by Google App Engine
This is Rietveld 408576698