src/preparser.h - Issue 885243002: Implement parsing of ES6 Rest Parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.h

Issue 885243002: Implement parsing of ES6 Rest Parameters (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: [parsing]: eval/arguments parameter names are ok in sloppy mode Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.h

diff --git a/src/preparser.h b/src/preparser.h

index c11bbd1629f66cf05aa0de2597504f8ede45a840..9f8fc13653a893d8c2adc7fcc2884773f2fd8f34 100644

--- a/src/preparser.h

+++ b/src/preparser.h

@@ -475,7 +475,7 @@ class ParserBase : public Traits {

bool* ok) {

if (is_sloppy(language_mode) && !strict_params) return;

- if (eval_args_error_loc.IsValid()) {

+ if (is_strict(language_mode) && eval_args_error_loc.IsValid()) {

Traits::ReportMessageAt(eval_args_error_loc, "strict_eval_arguments");

*ok = false;

return;

« no previous file with comments | « src/parser.cc ('k') | src/scopes.h » ('j') | no next file with comments »