Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 885083002: Set the quiet shutdown flag (Closed)

Created:
5 years, 10 months ago by haavardm
Modified:
5 years, 10 months ago
Reviewers:
davidben, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the quiet shutdown flag. Currently |SSL_shutdown| is only called to avoid that the session is marked as unresumable. Without the quiet flag the close notify message is generated without being sent on the network. BUG=None Committed: https://crrev.com/c80b0ee3708252814a0a20e795305ee2fc0ebc2f Cr-Commit-Position: refs/heads/master@{#313887}

Patch Set 1 #

Patch Set 2 : Put back SSL_shutdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
haavardm
David please review, Ryan FYI.
5 years, 10 months ago (2015-01-29 15:53:56 UTC) #2
davidben
lgtm
5 years, 10 months ago (2015-01-29 21:44:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/885083002/20001
5 years, 10 months ago (2015-01-30 08:23:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 09:16:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 09:18:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c80b0ee3708252814a0a20e795305ee2fc0ebc2f
Cr-Commit-Position: refs/heads/master@{#313887}

Powered by Google App Engine
This is Rietveld 408576698