Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 885083002: Set the quiet shutdown flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put back SSL_shutdown Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 504b702dc6614734df3894fb004168d4f6dad581..348528033e41b33fc8387d5d9a4f6c2b1b6f94cf 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -191,6 +191,10 @@ class SSLClientSocketOpenSSL::SSLContext {
SSL_CTX_set_cert_verify_callback(ssl_ctx_.get(), CertVerifyCallback, NULL);
SSL_CTX_set_cert_cb(ssl_ctx_.get(), ClientCertRequestCallback, NULL);
SSL_CTX_set_verify(ssl_ctx_.get(), SSL_VERIFY_PEER, NULL);
+ // This stops |SSL_shutdown| from generating the close_notify message, which
+ // is currently not sent on the network.
+ // TODO(haavardm): Remove setting quiet shutdown once 118366 is fixed.
+ SSL_CTX_set_quiet_shutdown(ssl_ctx_.get(), 1);
// TODO(kristianm): Only select this if ssl_config_.next_proto is not empty.
// It would be better if the callback were not a global setting,
// but that is an OpenSSL issue.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698