Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 884763003: Internals methods return 0 instead of false when they fail (Closed)

Created:
5 years, 10 months ago by grzegorz
Modified:
5 years, 10 months ago
Reviewers:
sof, shinyak
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Internals methods return 0 instead of false when they fail Some Internals method explicitly return 0 although they expect boolean value. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189813

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/core/testing/Internals.cpp View 1 9 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
grzegorz
5 years, 10 months ago (2015-02-05 14:29:06 UTC) #1
grzegorz
This brings no value but makes code base more consistent. I guess this mistake comes ...
5 years, 10 months ago (2015-02-06 14:35:39 UTC) #3
sof
lgtm
5 years, 10 months ago (2015-02-06 14:45:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884763003/1
5 years, 10 months ago (2015-02-07 08:41:32 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/testing/Internals.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 10 months ago (2015-02-07 09:56:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884763003/20001
5 years, 10 months ago (2015-02-09 08:11:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/121118) Timed out jobs are ...
5 years, 10 months ago (2015-02-09 10:28:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884763003/20001
5 years, 10 months ago (2015-02-09 10:32:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/45938)
5 years, 10 months ago (2015-02-09 11:54:54 UTC) #18
grzegorz
On 2015/02/09 11:54:54, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-09 13:09:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884763003/20001
5 years, 10 months ago (2015-02-09 15:25:30 UTC) #21
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:39:13 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189813

Powered by Google App Engine
This is Rietveld 408576698