Internals methods return 0 instead of false when they fail

Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 352 matching lines @@
     ASSERT(node);
     const TreeScope* parentTreeScope = node->treeScope().parentTreeScope();
     return parentTreeScope ? &parentTreeScope->rootNode() : 0;
 }
 
 bool Internals::hasSelectorForIdInShadow(Element* host, const AtomicString& idValue, ExceptionState& exceptionState)
 {
     ASSERT(host);
     if (!host->shadow()) {
         exceptionState.throwDOMException(InvalidAccessError, "The host element does not have a shadow.");
-        return 0;
+        return false;
     }
 
     return host->shadow()->ensureSelectFeatureSet().hasSelectorForId(idValue);
 }
 
 bool Internals::hasSelectorForClassInShadow(Element* host, const AtomicString& className, ExceptionState& exceptionState)
 {
     ASSERT(host);
     if (!host->shadow()) {
         exceptionState.throwDOMException(InvalidAccessError, "The host element does not have a shadow.");
-        return 0;
+        return false;
     }
 
     return host->shadow()->ensureSelectFeatureSet().hasSelectorForClass(className);
 }
 
 bool Internals::hasSelectorForAttributeInShadow(Element* host, const AtomicString& attributeName, ExceptionState& exceptionState)
 {
     ASSERT(host);
     if (!host->shadow()) {
         exceptionState.throwDOMException(InvalidAccessError, "The host element does not have a shadow.");
-        return 0;
+        return false;
     }
 
     return host->shadow()->ensureSelectFeatureSet().hasSelectorForAttribute(attributeName);
 }
 
 bool Internals::hasSelectorForPseudoClassInShadow(Element* host, const String& pseudoClass, ExceptionState& exceptionState)
 {
     ASSERT(host);
     if (!host->shadow()) {
         exceptionState.throwDOMException(InvalidAccessError, "The host element does not have a shadow.");
@@ skipping 25 matching lines @@
 
     frame()->view()->updateLayoutAndStyleForPainting();
     frame()->document()->timeline().pauseAnimationsForTesting(pauseTime);
 }
 
 bool Internals::hasShadowInsertionPoint(const Node* root, ExceptionState& exceptionState) const
 {
     ASSERT(root);
     if (!root->isShadowRoot()) {
         exceptionState.throwDOMException(InvalidAccessError, "The node argument is not a shadow root.");
-        return 0;
+        return false;
     }
     return toShadowRoot(root)->containsShadowElements();
 }
 
 bool Internals::hasContentElement(const Node* root, ExceptionState& exceptionState) const
 {
     ASSERT(root);
     if (!root->isShadowRoot()) {
         exceptionState.throwDOMException(InvalidAccessError, "The node argument is not a shadow root.");
-        return 0;
+        return false;
     }
     return toShadowRoot(root)->containsContentElements();
 }
 
 size_t Internals::countElementShadow(const Node* root, ExceptionState& exceptionState) const
 {
     ASSERT(root);
     if (!root->isShadowRoot()) {
         exceptionState.throwDOMException(InvalidAccessError, "The node argument is not a shadow root.");
         return 0;
@@ skipping 930 matching lines @@
         copyToVector(result.rectBasedTestResult(), matches);
     }
 
     return StaticNodeList::adopt(matches);
 }
 
 bool Internals::hasSpellingMarker(Document* document, int from, int length)
 {
     ASSERT(document);
     if (!document->frame())
-        return 0;
+        return false;
 
     return document->frame()->spellChecker().selectionStartHasMarkerFor(DocumentMarker::Spelling, from, length);
 }
 
 void Internals::setContinuousSpellCheckingEnabled(bool enabled)
 {
     if (!contextDocument() || !contextDocument()->frame())
         return;
 
     if (enabled != contextDocument()->frame()->spellChecker().isContinuousSpellCheckingEnabled())
         contextDocument()->frame()->spellChecker().toggleContinuousSpellChecking();
 }
 
 bool Internals::isOverwriteModeEnabled(Document* document)
 {
     ASSERT(document);
     if (!document->frame())
-        return 0;
+        return false;
 
     return document->frame()->editor().isOverwriteModeEnabled();
 }
 
 void Internals::toggleOverwriteModeEnabled(Document* document)
 {
     ASSERT(document);
     if (!document->frame())
         return;
 
@@ skipping 35 matching lines @@
     result.append(memoryCache()->maxDeadCapacity());
     result.append(memoryCache()->capacity());
     memoryCache()->setCapacities(minDeadBytes, maxDeadBytes, totalBytes);
     return result;
 }
 
 bool Internals::hasGrammarMarker(Document* document, int from, int length)
 {
     ASSERT(document);
     if (!document->frame())
-        return 0;
+        return false;
 
     return document->frame()->spellChecker().selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);
 }
 
 unsigned Internals::numberOfScrollableAreas(Document* document)
 {
     ASSERT(document);
     if (!document->frame())
         return 0;
 
@@ skipping 32 matching lines @@
 
 bool Internals::scrollsWithRespectTo(Element* element1, Element* element2, ExceptionState& exceptionState)
 {
     ASSERT(element1 && element2);
     element1->document().view()->updateLayoutAndStyleForPainting();
 
     LayoutObject* renderer1 = element1->renderer();
     LayoutObject* renderer2 = element2->renderer();
     if (!renderer1 || !renderer1->isBox()) {
         exceptionState.throwDOMException(InvalidAccessError, renderer1 ? "The first provided element's renderer is not a box." : "The first provided element has no renderer.");
-        return 0;
+        return false;
     }
     if (!renderer2 || !renderer2->isBox()) {
         exceptionState.throwDOMException(InvalidAccessError, renderer2 ? "The second provided element's renderer is not a box." : "The second provided element has no renderer.");
-        return 0;
+        return false;
     }
 
     Layer* layer1 = toRenderBox(renderer1)->layer();
     Layer* layer2 = toRenderBox(renderer2)->layer();
     if (!layer1 || !layer2) {
         exceptionState.throwDOMException(InvalidAccessError, String::format("No render layer can be obtained from the %s provided element.", layer1 ? "second" : "first"));
-        return 0;
+        return false;
     }
 
     return layer1->scrollsWithRespectTo(layer2);
 }
 
 String Internals::layerTreeAsText(Document* document, unsigned flags, ExceptionState& exceptionState) const
 {
     ASSERT(document);
     if (!document->frame()) {
         exceptionState.throwDOMException(InvalidAccessError, "The document provided is invalid.");
@@ skipping 785 matching lines @@
 {
     ThreadState::current()->schedulePreciseGC();
 }
 
 ValueIterable<int>::IterationSource* Internals::startIteration(ScriptState*, ExceptionState&)
 {
     return new InternalsIterationSource();
 }
 
 } // namespace blink