Remove ElevatedController

Remove ElevatedController and the associated registration and installation code.

BUG=453172
Committed: https://crrev.com/44157c0b0ef9d03d474529ffae4c14b443e141fc
Cr-Commit-Position: refs/heads/master@{#315599}

[weitao, 2015-02-07 01:25:07]

weitaosu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[weitao, 2015-02-07 01:27:42]

PTAL

https://codereview.chromium.org/884713010/diff/1/remoting/host/installer/win/...
File remoting/host/installer/win/chromoting.wxs (right):

https://codereview.chromium.org/884713010/diff/1/remoting/host/installer/win/...
remoting/host/installer/win/chromoting.wxs:571: }
ElevatedController.StartDaemon() did two things: change the service start type
to auto and start the service. But the former is not needed here because this
custom action is only executed if the service start type is auto.

[Sergey Ulanov, 2015-02-09 22:24:17]

Thanks for the cleanup!
I have one question about service auto-start script.

https://codereview.chromium.org/884713010/diff/1/remoting/host/installer/win/...
File remoting/host/installer/win/chromoting.wxs (right):

https://codereview.chromium.org/884713010/diff/1/remoting/host/installer/win/...
remoting/host/installer/win/chromoting.wxs:571: }
On 2015/02/07 01:27:42, weitaosu wrote:
> ElevatedController.StartDaemon() did two things: change the service start type
> to auto and start the service. But the former is not needed here because this
> custom action is only executed if the service start type is auto.

Is the service kept in auto-start mode when the package is upgraded. From the
comment above it looks like it's not and that's why this action was needed. Is
the comment wrong?

If we don't want to change auto-start mode then the action needs to be renamed.

[weitao, 2015-02-10 01:05:18]

https://codereview.chromium.org/884713010/diff/1/remoting/host/installer/win/...
File remoting/host/installer/win/chromoting.wxs (right):

https://codereview.chromium.org/884713010/diff/1/remoting/host/installer/win/...
remoting/host/installer/win/chromoting.wxs:571: }
On 2015/02/09 22:24:16, Sergey Ulanov wrote:
> On 2015/02/07 01:27:42, weitaosu wrote:
> > ElevatedController.StartDaemon() did two things: change the service start
type
> > to auto and start the service. But the former is not needed here because
this
> > custom action is only executed if the service start type is auto.
> 
> Is the service kept in auto-start mode when the package is upgraded. From the
> comment above it looks like it's not and that's why this action was needed. Is
> the comment wrong?
> 
> If we don't want to change auto-start mode then the action needs to be
renamed.

The comment is correct. The auto-start mode should only be changed by the user
when he enables/disables remote connection from the webapp. It should never be
changed by an upgrade.
I renamed the CA to start_chromoting_service.

[Sergey Ulanov, 2015-02-10 01:09:24]

lgtm

https://codereview.chromium.org/884713010/diff/40001/remoting/host/installer/...
File remoting/host/installer/win/chromoting.wxs (right):

https://codereview.chromium.org/884713010/diff/40001/remoting/host/installer/...
remoting/host/installer/win/chromoting.wxs:548: the service and change its
startup type as needed once the installation
We don't "change its startup type" anymore. Update the comment?

https://codereview.chromium.org/884713010/diff/40001/remoting/host/installer/...
remoting/host/installer/win/chromoting.wxs:562: <CustomAction
Id="start_chromoting_service"
maybe just "start_service"?

[weitao, 2015-02-10 17:56:35]

New patchsets have been uploaded after l-g-t-m from sergeyu@chromium.org

[weitao, 2015-02-10 17:57:14]

https://codereview.chromium.org/884713010/diff/40001/remoting/host/installer/...
File remoting/host/installer/win/chromoting.wxs (right):

https://codereview.chromium.org/884713010/diff/40001/remoting/host/installer/...
remoting/host/installer/win/chromoting.wxs:548: the service and change its
startup type as needed once the installation
On 2015/02/10 01:09:24, Sergey Ulanov wrote:
> We don't "change its startup type" anymore. Update the comment? 

Done.

https://codereview.chromium.org/884713010/diff/40001/remoting/host/installer/...
remoting/host/installer/win/chromoting.wxs:562: <CustomAction
Id="start_chromoting_service"
On 2015/02/10 01:09:24, Sergey Ulanov wrote:
> maybe just "start_service"?

I named it start_chromoting_service so that it is not confused
with the default StartServices action (which we don't run because
it doesn't honor the auto-start setting).

[weitao, 2015-02-10 17:57:19]

The CQ bit was checked by weitaosu@chromium.org

[commit-bot: I haz the power, 2015-02-10 17:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/884713010/60001

[commit-bot: I haz the power, 2015-02-10 18:48:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-10 18:48:57]

Patchset 4 (id:??) landed as
https://crrev.com/44157c0b0ef9d03d474529ffae4c14b443e141fc
Cr-Commit-Position: refs/heads/master@{#315599}