components/autofill/content/renderer/page_click_tracker.h - Issue 884583002: [autofill] Show autofill popup when focusing a field by tapping near its edge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 884583002: [autofill] Show autofill popup when focusing a field by tapping near its edge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bounds-change

Patch Set: Add a test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/page_click_tracker_browsertest.cc ('k') | components/autofill/content/renderer/page_click_tracker.cc » ('j') | components/autofill/content/renderer/page_click_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/page_click_tracker.h

diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h

index 9cb63535f64a64c36b1abb09595f3b393f75feca..3defe2ca55e1ca3cf8ebe7e5fcc6c8ff4b727a69 100644

--- a/components/autofill/content/renderer/page_click_tracker.h

+++ b/components/autofill/content/renderer/page_click_tracker.h

@@ -12,6 +12,10 @@

#include "content/public/renderer/render_view_observer.h"

#include "third_party/WebKit/public/web/WebNode.h"

+namespace gfx {

+class RectF;

namespace autofill {

class PageClickListener;

@@ -41,8 +45,9 @@ class PageClickTracker : public content::RenderViewObserver {

void FocusedNodeChanged(const blink::WebNode& node) override;

void FocusChangeComplete() override;

- // Called there is a tap or click at |x|, |y|.

- void PotentialActivationAt(int x, int y);

+ // Called if there is a tap or click at |region|. Clicks are 1x1 regions, but

+ // taps are wider.

+ void PotentialActivationAt(const gfx::RectF& region);

// The node that was clicked. Non-null only when the animations caused by

// focus change are still ongoing.