Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3837)

Unified Diff: chrome/renderer/autofill/page_click_tracker_browsertest.cc

Issue 884583002: [autofill] Show autofill popup when focusing a field by tapping near its edge. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bounds-change
Patch Set: Add a test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/page_click_tracker_browsertest.cc
diff --git a/chrome/renderer/autofill/page_click_tracker_browsertest.cc b/chrome/renderer/autofill/page_click_tracker_browsertest.cc
index 84231f682f5c6c2da8d012cd6d1711f032f64dcc..1bdd63f9c08cbb759eb36ef34bd856fcf2460d3a 100644
--- a/chrome/renderer/autofill/page_click_tracker_browsertest.cc
+++ b/chrome/renderer/autofill/page_click_tracker_browsertest.cc
@@ -189,4 +189,15 @@ TEST_F(PageClickTrackerTest, PageClickTrackerDisabledInputClickedNoEvent) {
EXPECT_FALSE(test_listener_.form_control_element_clicked_called_);
}
+TEST_F(PageClickTrackerTest, PageClickTrackerTapNearEdgeIsPageClick) {
+ EXPECT_NE(text_, text_.document().focusedElement());
+ // Tap outside of element bounds, but tap width is overlapping the field.
+ gfx::Rect element_bounds = GetElementBounds("text_1");
+ SimulateRectTap(element_bounds -
+ gfx::Vector2d(element_bounds.width() / 2 + 1, 0));
+ EXPECT_TRUE(test_listener_.form_control_element_clicked_called_);
+ EXPECT_FALSE(test_listener_.was_focused_);
+ EXPECT_TRUE(text_ == test_listener_.form_control_element_clicked_);
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698