Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 88453002: Calling isRenderedTable() instead of isTable() to maintain consistency within the Editing module. (Closed)

Created:
7 years ago by arpitab_
Modified:
7 years ago
Reviewers:
yosin_UTC9, ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Calling isRenderedTable() instead of isTable() to maintain consistency within the Editing module. Instead of doing the isTable() check on a node's renderer, we can directly use the htmlediting method isRenderedTable() that internally carries out the same check. This is to maintain consistency within the editing code. htmlediting defines two methods: isRenderedTable() and isTableElement() to perform a check based on the renderer, or the tag name respectively. Within the editing module, these methods should be called where required. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arpitab_
7 years ago (2013-11-26 14:45:15 UTC) #1
ojan
lgtm
7 years ago (2013-11-26 21:16:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/88453002/1
7 years ago (2013-11-26 21:16:47 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-26 23:39:40 UTC) #4
Message was sent while issue was closed.
Change committed as 162709

Powered by Google App Engine
This is Rietveld 408576698