Source/core/editing/TypingCommand.cpp - Issue 88453002: Calling isRenderedTable() instead of isTable() to maintain consistency within the Editing module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TypingCommand.cpp

Issue 88453002: Calling isRenderedTable() instead of isTable() to maintain consistency within the Editing module. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/TypingCommand.cpp

diff --git a/Source/core/editing/TypingCommand.cpp b/Source/core/editing/TypingCommand.cpp

index c68ecdaf7ff9d232b1c4f7a54cc184ee9e10b271..c71b240e45bdb6b7dc3f2627a926e3f520bf390c 100644

--- a/Source/core/editing/TypingCommand.cpp

+++ b/Source/core/editing/TypingCommand.cpp

@@ -530,8 +530,7 @@ void TypingCommand::forwardDeleteKeyPressed(TextGranularity granularity, bool ki

if (visibleEnd == endOfParagraph(visibleEnd))

downstreamEnd = visibleEnd.next(CannotCrossEditingBoundary).deepEquivalent().downstream();

// When deleting tables: Select the table first, then perform the deletion

- if (downstreamEnd.containerNode() && downstreamEnd.containerNode()->renderer() && downstreamEnd.containerNode()->renderer()->isTable()

- && downstreamEnd.computeOffsetInContainerNode() <= caretMinOffset(downstreamEnd.containerNode())) {

+ if (isRenderedTable(downstreamEnd.containerNode()) && downstreamEnd.computeOffsetInContainerNode() <= caretMinOffset(downstreamEnd.containerNode())) {

setEndingSelection(VisibleSelection(endingSelection().end(), positionAfterNode(downstreamEnd.containerNode()), DOWNSTREAM, endingSelection().isDirectional()));

typingAddedToOpenCommand(ForwardDeleteKey);

return;

« no previous file with comments | « Source/core/editing/TextIterator.cpp ('k') | Source/core/editing/htmlediting.cpp » ('j') | no next file with comments »