Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 884473004: Add is_external_protocol to NavigationParams (Closed)

Created:
5 years, 11 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, nasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add is_external_protocol to NavigationParams Java layer needs an exact way to determine whether a URL uses an external protocol or not. is_external_protocol will be true if a URL can't be handled by Chrome's internal protocol handlers. BUG=426751 Committed: https://crrev.com/2b5e3a6a705c4bb52be1f8a98aade49bd303ac58 Cr-Commit-Position: refs/heads/master@{#313606}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -26 lines) Patch
M components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java View 1 1 chunk +7 lines, -4 lines 0 comments Download
M components/navigation_interception/intercept_navigation_resource_throttle.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M components/navigation_interception/navigation_params.h View 3 chunks +4 lines, -1 line 0 comments Download
M components/navigation_interception/navigation_params.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M components/navigation_interception/navigation_params_android.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Jaekyun Seok (inactive)
Please review this CL.
5 years, 11 months ago (2015-01-28 04:05:15 UTC) #2
mnaganov (inactive)
LGTM Can you please update the description to include more information on what "external protocol" ...
5 years, 10 months ago (2015-01-28 17:06:48 UTC) #3
Jaekyun Seok (inactive)
On 2015/01/28 17:06:48, mnaganov (cr) wrote: > LGTM > > Can you please update the ...
5 years, 10 months ago (2015-01-28 21:20:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884473004/20001
5 years, 10 months ago (2015-01-28 21:30:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 23:13:42 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2b5e3a6a705c4bb52be1f8a98aade49bd303ac58 Cr-Commit-Position: refs/heads/master@{#313606}
5 years, 10 months ago (2015-01-28 23:14:47 UTC) #8
please use gerrit instead
Hi, I'm investigating flakiness in org.chromium.chrome.browser.RepostFormWarningTest#testFormResubmissionCancel. This patch was in the earliest build that I ...
5 years, 10 months ago (2015-01-30 22:09:20 UTC) #9
Jaekyun Seok (inactive)
5 years, 10 months ago (2015-02-01 21:26:34 UTC) #10
Message was sent while issue was closed. 
On 2015/01/30 22:09:20, Rouslan Solomakhin wrote:
> Hi, I'm investigating flakiness in
> org.chromium.chrome.browser.RepostFormWarningTest#testFormResubmissionCancel.
> This patch was in the earliest build that I can find with this test failure.
Do
> you think it could be related?
> 
> C  189.321s Main 
>
********************************************************************************
> C  189.321s Main  Detailed Logs
> C  189.321s Main 
>
********************************************************************************
> C  189.322s Main  [FAIL]
> org.chromium.chrome.browser.RepostFormWarningTest#testFormResubmissionCancel:
> C  189.322s Main  java.util.concurrent.TimeoutException: waitForCallback timed
> out!
> C  189.322s Main  	at
>
org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:184)
> C  189.322s Main  	at
>
org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:192)
> C  189.322s Main  	at
>
org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:198)
> C  189.322s Main  	at
>
org.chromium.chrome.browser.RepostFormWarningTest.setUp(RepostFormWarningTest.java:36)
> C  189.323s Main  	at
> android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
> C  189.323s Main  	at
> android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
> C  189.323s Main  	at
>
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
> C  189.323s Main  	at
>
org.chromium.chrome.test.ChromeInstrumentationTestRunner.onStart(ChromeInstrumentationTestRunner.java:83)
> C  189.323s Main  	at
>
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
> C  189.323s Main 
>
********************************************************************************
> C  189.323s Main  Summary
> C  189.323s Main 
>
********************************************************************************
> C  189.324s Main  [==========] 331 tests ran.
> C  189.324s Main  [  PASSED  ] 330 tests.
> C  189.325s Main  [  FAILED  ] 1 test, listed below:
> C  189.325s Main  [  FAILED  ]
> org.chromium.chrome.browser.RepostFormWarningTest#testFormResubmissionCancel
> C  189.325s Main  
> C  189.325s Main  1 FAILED TEST
> C  189.325s Main 
>
********************************************************************************
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

The failure doesn't seem to related to this CL because it only checks whether a
URL uses an external
protocol or not, and saves the value.

Powered by Google App Engine
This is Rietveld 408576698