Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java

Issue 884473004: Add is_external_protocol to NavigationParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/navigation_interception/intercept_navigation_resource_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
diff --git a/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java b/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
index 3da5a7496efba4201b742636a7eaa37228bb5718..5e27176609e5b0ecab25bf66015b117e61dd653b 100644
--- a/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
+++ b/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
@@ -17,20 +17,23 @@ public class NavigationParams {
public final int pageTransitionType;
// Is the navigation a redirect (in which case url is the "target" address).
public final boolean isRedirect;
+ // True if the target url can't be handled by Chrome's internal protocol handlers.
+ public final boolean isExternalProtocol;
public NavigationParams(String url, boolean isPost, boolean hasUserGesture,
- int pageTransitionType, boolean isRedirect) {
+ int pageTransitionType, boolean isRedirect, boolean isExternalProtocol) {
this.url = url;
this.isPost = isPost;
this.hasUserGesture = hasUserGesture;
this.pageTransitionType = pageTransitionType;
this.isRedirect = isRedirect;
+ this.isExternalProtocol = isExternalProtocol;
}
@CalledByNative
public static NavigationParams create(String url, boolean isPost, boolean hasUserGesture,
- int pageTransitionType, boolean isRedirect) {
- return new NavigationParams(url, isPost, hasUserGesture, pageTransitionType,
- isRedirect);
+ int pageTransitionType, boolean isRedirect, boolean isExternalProtocol) {
+ return new NavigationParams(
+ url, isPost, hasUserGesture, pageTransitionType, isRedirect, isExternalProtocol);
}
}
« no previous file with comments | « no previous file | components/navigation_interception/intercept_navigation_resource_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698