Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 884213005: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=bauerb@chromium.org Committed: https://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b Cr-Commit-Position: refs/heads/master@{#314618}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -210 lines) Patch
M chrome/browser/android/accessibility/font_size_prefs_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/android/bookmarks/bookmarks_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.h View 1 1 chunk +34 lines, -35 lines 0 comments Download
M chrome/browser/android/dev_tools_manager_delegate_android.h View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/browser/android/dev_tools_manager_delegate_android.cc View 7 chunks +18 lines, -30 lines 0 comments Download
M chrome/browser/android/dom_distiller/feedback_reporter_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/foreign_session_helper.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/android/intercept_download_resource_throttle.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/logo_bridge.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/android/logo_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/logo_service.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/android/most_visited_sites.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/omnibox/answers_image_bridge.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/password_ui_view_android.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/bookmark_model_observer_task.h View 1 chunk +23 lines, -24 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/android/recently_closed_tabs_bridge.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/shortcut_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/signin/signin_manager_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/signin/signin_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.h View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/android/thumbnail/thumbnail.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/thumbnail/thumbnail_store.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/webapps/single_tab_mode_tab_helper.h View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:48:15 UTC) #1
Bernhard Bauer
lgtm
5 years, 10 months ago (2015-02-04 10:55:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884213005/1
5 years, 10 months ago (2015-02-04 18:38:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/55402) ios_rel_device_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/7343) ios_rel_device_ninja_ng ...
5 years, 10 months ago (2015-02-04 18:42:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884213005/20001
5 years, 10 months ago (2015-02-04 19:23:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 20:12:21 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:13:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7241f5fdbb0c7de0beddf61fb16cbc0a224eaa8b
Cr-Commit-Position: refs/heads/master@{#314618}

Powered by Google App Engine
This is Rietveld 408576698