chrome/browser/android/banners/app_banner_manager.h - Issue 884213005: Update {virtual,override,final} to follow C++11 style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager.h

Issue 884213005: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/accessibility/font_size_prefs_android.h ('k') | chrome/browser/android/bookmarks/bookmarks_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_manager.h

diff --git a/chrome/browser/android/banners/app_banner_manager.h b/chrome/browser/android/banners/app_banner_manager.h

index c65d1479a5e62c29b3fe2019f5a223e7cdda43ec..12ae72a3c791e5add2dff3635a96281599a3ce1e 100644

--- a/chrome/browser/android/banners/app_banner_manager.h

+++ b/chrome/browser/android/banners/app_banner_manager.h

@@ -64,7 +64,7 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,

public AppBannerInfoBarDelegate::AppDelegate {

public:

AppBannerManager(JNIEnv* env, jobject obj);

- virtual ~AppBannerManager();

+ ~AppBannerManager() override;

// Destroys the AppBannerManager.

void Destroy(JNIEnv* env, jobject obj);

@@ -93,20 +93,20 @@ class AppBannerManager : public chrome::BitmapFetcherDelegate,

const SkBitmap& icon);

// WebContentsObserver overrides.

- virtual void DidNavigateMainFrame(

+ void DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- virtual void DidFinishLoad(content::RenderFrameHost* render_frame_host,

- const GURL& validated_url) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void DidFinishLoad(content::RenderFrameHost* render_frame_host,

+ const GURL& validated_url) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// BitmapFetcherDelegate overrides.

- virtual void OnFetchComplete(const GURL url, const SkBitmap* bitmap) override;

+ void OnFetchComplete(const GURL url, const SkBitmap* bitmap) override;

// AppBannerInfoBarDelegate::AppDelegate overrides.

- virtual void Block() const override;

- virtual void Install() const override;

- virtual gfx::Image GetIcon() const override;

+ void Block() const override;

+ void Install() const override;

+ gfx::Image GetIcon() const override;

private:

// Gets the preferred icon size for the banner icons.