Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 884093003: Propagate push command line flag to the renderer process. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, leviw_travelin_and_unemployed, nasko+codewatch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Propagate push command line flag to the renderer process. The renderer is using this to conditionally enable payload API surface for incoming push messages, and thus needs to know about it. This patch also re-enables the tests. BUG=452666 Committed: https://crrev.com/7c1ea69b125d6c489ac68e3dd2eef454f9134b9f Cr-Commit-Position: refs/heads/master@{#313500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/services/gcm/push_messaging_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Beverloo
+jochen for a one-liner? :)
5 years, 10 months ago (2015-01-28 11:49:41 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-01-28 11:50:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884093003/1
5 years, 10 months ago (2015-01-28 11:52:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/49451)
5 years, 10 months ago (2015-01-28 12:48:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/884093003/1
5 years, 10 months ago (2015-01-28 13:02:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 13:50:21 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 13:51:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c1ea69b125d6c489ac68e3dd2eef454f9134b9f
Cr-Commit-Position: refs/heads/master@{#313500}

Powered by Google App Engine
This is Rietveld 408576698